0 Members and 1 Guest are viewing this topic.

*

christianrein

  • *
  • 1
  • osDate Version: osDate Evo v1.2
Bug in completereg.php ?
« on: May 14, 2017, 11:03:40 PM »
Hello,

is this code correct in completereg.php:

Code: [Select]
session_destroy();

header('location: index.php?page=login&err='.REGN_COMPLETED);

} else {

header( 'location: confirmreg.php?errid='.INVALID_ACTIVATION_CODE );

}

exit;
?>

or should it be:

Code: [Select]
session_destroy();

header('location: index.php?page=login&errid='.REGN_COMPLETED);

} else {

header( 'location: confirmreg.php?errid='.INVALID_ACTIVATION_CODE );

}

exit;
?>

I changed header('location: index.php?page=login&errid='.REGN_COMPLETED); in my code. Hope this was correct. I am creating a german page and had many problems with translations. So i hope this change was correct instead of having another translation problem.

Thanks

« Last Edit: May 15, 2017, 10:19:14 AM by Pharg »

*

Pharg

  • *****
  • 3,272
    • OsDateFourm
  • osDate Version: osDateEvo v1.3
Re: Bug in completereg.php ?
« Reply #1 on: May 14, 2017, 11:55:20 PM »
Hi christianrein,

Yes you could be right there.

Will check it on the main download.
« Last Edit: May 15, 2017, 12:01:24 AM by Pharg »
Regards,
Pharg ( Phill )

Don't Personal Message me unless it's about a sensitive matter!!

REMEMBER TO ALWAYS BACKUP BEFORE MAKING ANY CHANGES!!

osDateEvo v1.3 | PHP: 5.3.42 & PHP: 7.2 | MySQL: 5.5.35

*

Pharg

  • *****
  • 3,272
    • OsDateFourm
  • osDate Version: osDateEvo v1.3
Re: Bug in completereg.php ?
« Reply #2 on: May 15, 2017, 01:59:35 AM »
Hello,

is this code correct in completereg.php:

Code: [Select]
session_destroy();

header('location: index.php?page=login&err='.REGN_COMPLETED);

} else {

header( 'location: confirmreg.php?errid='.INVALID_ACTIVATION_CODE );

}

exit;
?>

or should it be:

Code: [Select]
session_destroy();

header('location: index.php?page=login&errid='.REGN_COMPLETED);

} else {

header( 'location: confirmreg.php?errid='.INVALID_ACTIVATION_CODE );

}

exit;
?>

I changed header('location: index.php?page=login&errid='.REGN_COMPLETED); in my code. Hope this was correct. I am creating a german page and had many problems with translations. So i hope this change was correct instead of having another translation problem.

Thanks

Hi christianrein,

Nicely spotted, this has been like this for many years and only would have only gotten noticed by those that use
Promo codes on there sites.

Using Promo code reg completed, this affects and now shows correctly.

Normal complete reg this doesn't affect at all.

Thanks christianrein
« Last Edit: May 15, 2017, 10:19:58 AM by Pharg »
Regards,
Pharg ( Phill )

Don't Personal Message me unless it's about a sensitive matter!!

REMEMBER TO ALWAYS BACKUP BEFORE MAKING ANY CHANGES!!

osDateEvo v1.3 | PHP: 5.3.42 & PHP: 7.2 | MySQL: 5.5.35